-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FlatFileItemWriter now uses charset to determine default encoding #3910
Conversation
*/ | ||
public class FlatFileItemWriter<T> extends AbstractFileItemWriter<T> { | ||
|
||
protected LineAggregator<T> lineAggregator; | ||
|
||
// default encoding for writing to flat files - set to charset of this Java virtual machine. | ||
public static final String DEFAULT_CHARSET = Charset.defaultCharset().name(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a DEFAULT_CHARSET constant in AbstractFileItemWriter. It is that value that should be changed instead of adding a new constant here.
resolves spring-projects#1154 It now matches the encoding scheme of FlatFileItemReader
I will update this in the PR. The issue mentions |
f3ae970
to
23a7b6b
Compare
resolves #1154
It now matches the encoding scheme of FlatFileItemReader